Merged
Conversation
slivingston
reviewed
Dec 30, 2023
Contributor
Either this or the other way round. Python 3.12 requires numpy 1.26 on conda, already triggering the deprecation warnings. I had to disable them for the Slycot CI: https://github.com/python-control/Slycot/pull/227/files#diff-b2cf1d5b6cad7a0f6a749da416cb8a4e34040b2164a84a651783692d4b60d608R17 |
Member
Author
|
Looks like there were no conflicts, so going ahead and merging. @bnavigator: FYI (and not really for this PR), I tried updating GitHub actions to use Python 3.12 but mamba caused problems, so I'm waiting until that clears. You can find the attempt here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a bunch of small changes to remove warning messages in the GitHub actions CI runs:
item()(old usage is newly deprecated in NumPy).set_tight_layout(True)tofig.set_layout_engine('tight')(newly deprecated in Matplotlib).connect(which are OK for now).Note: it is likely that this PR will conflict with #953. We should probably merge #953 first and then rebase this PR since the changes here are pretty straightforward.