feat(api): add project.transfer() and deprecate transfer_project()#1833
Merged
JohnVillalovos merged 2 commits intomainfrom Jan 14, 2022
Merged
feat(api): add project.transfer() and deprecate transfer_project()#1833JohnVillalovos merged 2 commits intomainfrom
project.transfer() and deprecate transfer_project()#1833JohnVillalovos merged 2 commits intomainfrom
Conversation
nejch
force-pushed
the
feat/transfer-method
branch
from
693c270 to
1e24c85
Compare
Codecov Report
@@ Coverage Diff @@
## main #1833 +/- ##
==========================================
+ Coverage 92.20% 92.25% +0.04%
==========================================
Files 77 77
Lines 4834 4839 +5
==========================================
+ Hits 4457 4464 +7
+ Misses 377 375 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: John Villalovos <[email protected]>
JohnVillalovos
approved these changes
Jan 13, 2022
Member
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
Thanks. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to bring things in line with #1807.
transfer_projectwas very confusing already as the direction of transfer can differ depending on the endpoint, see other PR for discussion.