Fix #194 and #114: Update semver regex to version from semver.org#198
Merged
s-celles merged 1 commit intopython-semver:masterfrom Nov 24, 2019
Merged
Fix #194 and #114: Update semver regex to version from semver.org#198s-celles merged 1 commit intopython-semver:masterfrom
s-celles merged 1 commit intopython-semver:masterfrom
Conversation
tomschr
reviewed
Nov 20, 2019
Member
tomschr
left a comment
tomschr
left a comment
There was a problem hiding this comment.
Thanks, that is awesome! 👍 Just one comment. 😉
tomschr
added
the
Bug
Member
|
Nice catch about super call with Py 2.7 |
…ersion from semver.org Also, fix problem with invalid Python 2.7 super call.
ppkt
force-pushed
the
update-semver-regex
branch
from
bab5bc0 to
508dcf4
Compare
Member
Member
Member
Author
|
@scls19fr of course, I'll do this in next PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a regex from https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string , splitted it into multiple lines to match current format and renamed
buildmetadata->build. Also, I found and fix a problem with invalid Python 2.7 super call :)