chore: some Cython 3.1.0rc1 build failures#1574
Merged
bdraco merged 1 commit intopython-zeroconf:masterfrom May 3, 2025
Merged
chore: some Cython 3.1.0rc1 build failures#1574bdraco merged 1 commit intopython-zeroconf:masterfrom
bdraco merged 1 commit intopython-zeroconf:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1574 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 33 33
Lines 3400 3400
Branches 461 461
=======================================
Hits 3392 3392
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1574 will not alter performanceComparing Summary
|
Contributor
Author
|
Removed the other change, as apparently there is no way to satisfy both ruff and cython, and limited this to that one clear fix. |
Fix `AsyncListener._respond_query()` to use `DNSIncoming` type
for the `msg` argument, matching `handle_query_or_defer()`. This fixes
the following error with Cython 3.1.0rc1:
```
Error compiling Cython file:
------------------------------------------------------------
...
def _cancel_any_timers_for_addr(self, addr: _str) -> None:
"""Cancel any future truncated packet timers for the address."""
if addr in self._timers:
self._timers.pop(addr).cancel()
def _respond_query(
^
------------------------------------------------------------
src/zeroconf/_listener.py:225:4: Signature not compatible with previous declaration
Error compiling Cython file:
------------------------------------------------------------
...
object port,
object transport,
tuple v6_flow_scope
)
cpdef _respond_query(
^
------------------------------------------------------------
src/zeroconf/_listener.pxd:51:24: Previous declaration is here
```
Contributor
Author
|
Okay, so the other problem is that |
Member
|
change to chore so it doesn't release. Will try to fix a few more and than do a fix one at the end |
Member
|
Thanks @mgorny |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the few build failures I've hit with Cython 3.1.0rc1. Unfortunately, I'm stuck at:
and the like. I suspect it doesn't like
override_ttlsbut can't figure out how to make it work.