Conversation
Contrary to what I said before, I don't think trying to provide a single DLL for Python 2 and 3. We will in the future default to Python 3, and if someone really wants Python 2, for a while we will support a separate compile configuration for that.
|
@filmor this is the first stage I described (although I couldn't figure out what you mean by custom IncRef and DecRef) |
lostmsu
left a comment
lostmsu
left a comment
There was a problem hiding this comment.
Seems fine to me, but must fix CI.
|
@filmor if this is targeting Python.NET 3+, I think we should just drop Python 2 support altogether with all related code. Keeping those We can just remove all Python 2-related code in a single commit, including the CI checks. Whoever needs it then can just revert it and try to work from there (which I doubt will ever happen). @koubaa @filmor in my branch I simply use a static check using RuntimeInformation.IsOSPlatform to decide between UCS2 and UCS4, then just cache boolean flag. I don't think it has any significant impact on performance as opposed to using |
3 participants
What does this implement/fix? Explain your changes.
pulls out a first stage from this PR:
https://github.com/pythonnet/pythonnet/pull/1109/files
...
Does this close any currently open issues?
no
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG