Conversation
Contributor
|
do you mean this warning? https://ci.appveyor.com/project/pythonnet/pythonnet/build/master-377/job/rpml92u11q1k5kl8#L484 |
den-run-ai
approved these changes
Feb 9, 2017
Contributor
Author
|
That one. |
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 63.18% 63.19% +0.01%
==========================================
Files 61 61
Lines 5239 5239
Branches 876 876
==========================================
+ Hits 3310 3311 +1
Misses 1709 1709
+ Partials 220 219 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
Fixed the aforementioned coverage issue. @filmor did you still want to upgrade to NUnit3? |
NUnit3/OpenCover behavior changed. Filter removes coverage from Embedded test files by focusing only on types of Python.Runtime.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Since the embedded unit tests have been patched we can re-upgrade to
NUnit3from @filmor .Does this close any currently open issues?
N/AAny other comments?
On
v.2.xof NUnit I'm noticing that the tests finish and hang for ~40 seconds before releasing control. onv3.xit gives some warnings but I'm not sure if thats related.Personally I'm indifferent to prefer
v2.xsince it released control and occasionally print the traceback that was key to figuring the old problem out. But since that looks to be solved, I don't have a strong argument.