Fix missing Incref for Namespace and Assembly#482
Conversation
Fix crash of python interpreter 3.5 64-bit in garbage collector
|
Well, tests failed on mono with python 3.4. I have VM with Ubuntu 14.04 & mono 4.6 & python 3.4 64-bit. Any help how to get these tests runing? |
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 68.56% 68.53% -0.03%
==========================================
Files 63 63
Lines 5344 5346 +2
Branches 855 855
==========================================
Hits 3664 3664
- Misses 1444 1446 +2
Partials 236 236
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=========================================
+ Coverage 68.34% 73.15% +4.8%
=========================================
Files 64 61 -3
Lines 5560 5483 -77
Branches 894 883 -11
=========================================
+ Hits 3800 4011 +211
+ Misses 1496 1164 -332
- Partials 264 308 +44
Continue to review full report at Codecov.
|
|
@testrunner123 the tests are now passing on Travis CI (Mono). I'm not sure about your "__Internal" issue, maybe @vmuriart or @dmitriyse know? |
|
@denfromufa are you closing and re-openning the issues to trigger the builds? You can re-trigger the builds on Travis/AppVeyor on each one's webpage. I think AppVeyor's had a bug though, or annoyance... I think you can only retrigger all Versions instead of just a couple specific ones. @testrunner123 did you say this fixed #422 as well? |
|
@vmuriart |
|
@denfromufa |
|
@testrunner123 i approved this pull request, but let's keep the original issue open due to this comment from @filmor. This bigger issue can be addressed in another pull request: Regarding "internal" let me test this locally. There is another non-reproducible issue with "internal": #445 |
|
Before merging, could you go through the checklist? |
|
@denfromufa |
|
@testrunner123 can you please update changelog and authors list? https://github.com/pythonnet/pythonnet/blob/master/AUTHORS.md |
|
@denfromufa |
Fix crash of python interpreter 3.5 64-bit in garbage collector
Fix crash of python interpreter 3.5 64-bit in garbage collector
What does this implement/fix? Explain your changes.
If Python class is derived from .NET class and namespace or assembly attributes are set then python interpreter crashes in garbage collector. Provoke garbage collector run by:
Does this close any currently open issues?
#481 and may be others
Any other comments?
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG