Handle C long size on Windows.#497
Conversation
On Windows 64bit systems, a C `long` is a 32 bit integer while the rest of the world has agreed on making `sizeof(long) == sizeof(void*)`.
|
@filmor, thanks! @vmuriart, @tiran, @brianlloyd, @hsoft and @tonyroberts, please review this. |
|
@filmor tp_flags is c_long in Python 2.7 and unsigned c_long in Python 3.6. This may not fit into CLR |
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
- Coverage 76.38% 76.33% -0.06%
==========================================
Files 64 65 +1
Lines 5573 5582 +9
Branches 896 898 +2
==========================================
+ Hits 4257 4261 +4
- Misses 1021 1024 +3
- Partials 295 297 +2
Continue to review full report at Codecov.
|
|
Does it matter, though? Bitwise it doesn't make a difference, and I'm reading the actual value of |
On Windows 64bit systems, a C `long` is a 32 bit integer while the rest of the world has agreed on making `sizeof(long) == sizeof(void*)`.
3 participants
On Windows 64bit systems, a C
longis a 32 bit integer while the restof the world has agreed on making
sizeof(long) == sizeof(void*).What does this implement/fix? Explain your changes.
New attempt on #376
Any other comments?
@vmuriart Do you have a test-case for PR #376?
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG