allow .NET classes to override __getattr__ and __setattr__#901
allow .NET classes to override __getattr__ and __setattr__#901lostmsu wants to merge 3 commits intopythonnet:masterfrom
Conversation
|
Looks like .csproj files have varying line endings. Do you guys know how to enforce them in the future? |
|
@filmor any idea why that change could have broken x86 tests? I just tried to run Python.EmbeddingTest on Windows with x86, and did not get any crashes or issue? Could it be, that a simple rerun needed (then how to do it?)? |
|
It looks good now. Regarding the line endings: IMO we should always have Unix style line-endings everywhere. We could set up a I use the setting |
|
@filmor I don't think it does. x86 builds are still failing in appveyor (unlike, for example, trivial C# version change). |
|
Damn, Hyper-V on Windows 10 does not boot x86 linuxes (tried Ubuntu 16.04, 18.04 and the latest Debian) |
…ests crashing under x86 (opened bug pythonnet#946)
|
Closing this out, as we decided on ad-hoc approach instead (e.g. one should simply have a |
2 participants
What does this implement/fix? Explain your changes.
This enables .NET classes to override
__getattr__and__setattr__by implementingIGetAttrandISetAttrinterfaces correspondingly.How does it work
When constructing a Python type, that will represent C# type, if the C# type implements one of the interfaces, fill corresponding slots in the Python type with custom handlers for
tp_getattroortp_setattrowith implementations fromslots.cs.Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOGP.S.
This is a single-commit change. Probably could be cherry-picked merged without a merge commit.