Bump PHPUnit version#391
Closed
carusogabriel wants to merge 1 commit intoreactphp:masterfrom
carusogabriel:phpunit
Closed
Bump PHPUnit version#391carusogabriel wants to merge 1 commit intoreactphp:masterfrom carusogabriel:phpunit
carusogabriel wants to merge 1 commit intoreactphp:masterfrom
carusogabriel:phpunit
Conversation
Member
|
Thank you for filing this PR! I agree that adding support for newer PHPUnit versions makes perfect sense, much appreciated! However, this one is currently a bit unclear, what is the motivation for this change? |
Author
|
As I've updated PHPUnit to several |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump PHPUnit version to
~4.8.35, to follow several changes made through Reactphp repos.