Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor and clean up some parts of the template:
upstream_namewas set in$globals.vhoststwo times, in theVIRTUAL_HOSTandVIRTUAL_HOST_MULTIPORTSloops. It's been deduplicated to the third loop over$globals.vhosts.when (hasKey $fooDict $bar) (get $fooDict $bar) "defaultValue"has been replaced with the slightly clearerget $fooDict $bar | default "defaultValue".legacyfor containers usingVIRTUAL_HOST.and fix a few things on the debug endpoint:
\ncharacter to the response so thatcurl | jqon the endpoint work correctly.RuntimeContainerstruct of the additional containers where incorrectly kept, resulting in thepathsbeing stripped from the response.Due to the aforementioned removal of the
legacyport logic, this configuration:Now result in this in the
vhost.pathssection of the debug endpoint response:{ "/":{ "dest":"", "keepalive":"auto", "network_tag":"external", "ports":{ "8077":[ { "Name":"compose-app2-1" }, { "Name":"compose-app1-1" }, { "Name":"compose-app3-1" } ] }, "proto":"http", "upstream":"nginx-proxy.tld" } }instead of this previously:
{ "/":{ "dest":"", "keepalive":"auto", "network_tag":"external", "ports":{ "8077":[ { "Name":"compose-app3-1" } ], "legacy":[ { "Name":"compose-app2-1" }, { "Name":"compose-app1-1" } ] }, "proto":"http", "upstream":"nginx-proxy.tld" } }The resulting nginx configuration is inchanged.