Adds reflection hints for native-image support 1.1.x#1073
Merged
OlegDokuka merged 1 commit intorsocket:1.1.xfrom Sep 13, 2022
violetagg:native-image-configuration-1_1_x
Merged
Adds reflection hints for native-image support 1.1.x#1073OlegDokuka merged 1 commit intorsocket:1.1.xfrom violetagg:native-image-configuration-1_1_x
OlegDokuka merged 1 commit intorsocket:1.1.xfrom
violetagg:native-image-configuration-1_1_x
Conversation
Signed-off-by: Violeta Georgieva <[email protected]>
OlegDokuka
approved these changes
Sep 13, 2022
OlegDokuka
pushed a commit
that referenced
this pull request
Sep 13, 2022
Signed-off-by: Oleh Dokuka <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The issues below are observed when trying to test rsocket native-image support
1.
ChannelHandleris added to theNettychannel pipeline,io.netty.channel.ChannelHandlerMask#mask0will inspect theChannelHandler'smethods forio.netty.channel.ChannelHandlerMask.Skipannotation.When there are no reflection hints,
NoSuchMethodExceptionis thrown when trying to query the methods.This will lead to methods marked as not skippable, although the program will be able to run
without any problems, when all methods are marked as not skippable, one might observe performance issues.
Modifications:
jctools queuesChannelHandler'sResult:
No issues when testing rsocket native-image support