Ensure Subscriber is removed from sendingSubscriptions#962
Merged
rstoyanchev merged 1 commit intorsocket:1.0.xfrom Nov 25, 2020
Merged
Ensure Subscriber is removed from sendingSubscriptions#962rstoyanchev merged 1 commit intorsocket:1.0.xfrom
rstoyanchev merged 1 commit intorsocket:1.0.xfrom
Conversation
OlegDokuka
requested changes
Nov 20, 2020
Member
There was a problem hiding this comment.
Let's do it a little differently. Let's remove the subscriber right immediately at the onNext method. Spec says that in the case of NEXT_COMPLETE no frames should be sent.
Thus, we should consider only 3 possible outcomes:
onNext -> remove subscriber and send the NEXT_COMPLETE frame
only onComplete -> remove subscriber and send the COMPLETE frame
only onError -> remove subscriber and send the ERROR frame
if
onNext + onComplete (do nothing at onComplete)
onNext + onError (drop error at onError)
Closes rsocketgh-961 Signed-off-by: Rossen Stoyanchev <[email protected]>
rstoyanchev
force-pushed
the
961-sendingSubscriptions
branch
from
a7000fa to
ae94de0
Compare
Contributor
Author
Good idea, I've updated the PR accordingly. |
Contributor
|
@OlegDokuka could you release 1.0.4 to include this bug fix? it's very important for Spring Boot 2.3.X. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #961.