require login for note #13775
Open
require login for note #13775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a login requirement for the note-taking feature at connection end. The changes ensure that the audit server functionality and note collection only work when a user is logged in (has an access token).
- Added access token validation in Rust backend before returning audit server URL
- Added audit server check in Flutter before querying audit GUID
- Updated UI elements across mobile and desktop platforms to indicate login requirement
- Fixed a typo in Vietnamese language file and added new translation key across all language files
Reviewed changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ui_session_interface.rs | Added access token check to return empty string if user not logged in before returning audit server URL |
| flutter/lib/models/model.dart | Added early return if audit server is empty (no login), preventing unnecessary audit GUID queries; also reformatted display parameter assignment |
| flutter/lib/mobile/pages/settings_page.dart | Updated note setting title to indicate login requirement by appending "(Requires login)" |
| flutter/lib/desktop/pages/desktop_setting_page.dart | Wrapped note checkbox with Tooltip showing "Requires login" message on hover |
| src/lang/vi.rs | Fixed corrupted translation key and added 24 missing translation entries including the new "Requires login" key |
| src/lang/*.rs (multiple files) | Added "Requires login" translation key across all language files (mostly as empty strings for future translation, except Chinese which has translation) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: 21pages <[email protected]>
21pages
force-pushed
the
require_login_for_note
branch
from
15424ab to
e7949d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13499