Inherit Makefile Integration Tests command for hooks #1028
Merged
Conversation
Signed-off-by: Rami Souai <[email protected]>
Signed-off-by: Rami Souai <[email protected]>
RamiSouai
added
bug
Signed-off-by: Simon Hülkenberg <[email protected]>
RamiSouai
changed the title
2 tasks
Ilyesbdlala
added
planned
Weltraumschaf
requested changes
Mar 16, 2022
Member
Weltraumschaf
left a comment
Weltraumschaf
left a comment
There was a problem hiding this comment.
LGTM. Only .PHONY tags we should add to at least all touched Makefiles.
As requested in the review Signed-off-by: Ilyes Ben Dlala <[email protected]>
This is done to include the semgrep integration test fix
…ook folder This is done so these tests would run when "make integration tests" is called in the cascading-scan hook folder This goes hand in hand with issue #890 Signed-off-by: Ilyes Ben Dlala <[email protected]>
| include ../../hooks.mk | ||
|
|
||
| .PHONY: test-2 | ||
| test-2: | clean-integration-tests unit-tests docker-build docker-export kind-import deploy deploy-test-deps-2 integration-tests-2 |
Member
There was a problem hiding this comment.
What does the | here? Never seen this before and I'm too stupid to google it...
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Second question: What does the 2 mean in the target name? We should avoid magic numbers in names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The integration-test command for hooks is now the same for all hooks, and uses npm run tests (With the exception of Persistance-DefectDojo which is in Java).
Now each hook can decide for itself what the
npm run testcommand does in it's package.json file. For example, notification and cascading-scans hooks, which are in Typescript, add an extra build step.Checklist
npm testruns for the whole project.