-
Notifications
You must be signed in to change notification settings - Fork 178
Inherit Makefile Integration Tests command for hooks #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3d11c99
Delete redundant make integration-tests in hook folders
RamiSouai 13fedab
Unify make integration-tests for hooks to avoid inheriting make commands
RamiSouai 40e73d8
Use hook spedific package.json when running integration tests
the-simmon 56be035
Added .PHONY to all non-file make targets for hooks makefiles
Ilyesbdlala d4f69db
Merge branch 'main' into maintenance/generic-makefile-hooks
Ilyesbdlala 81072fb
Moved cascading-scan tests from tests/integration to cascading scan h…
Ilyesbdlala 4677af1
Merge branch 'main' into maintenance/generic-makefile-hooks
rfelber 5ba48ce
Moved integration test to correct folder
rfelber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
hooks/cascading-scans/integration-tests/cascade-nmap-ncrack.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // SPDX-FileCopyrightText: the secureCodeBox authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| const { cascadingScan } = require("../../../tests/integration/helpers"); | ||
|
|
||
| jest.retryTimes(3); | ||
|
|
||
| test( | ||
| "Cascading Scan nmap -> ncrack on dummy-ssh", | ||
| async () => { | ||
| const { categories, severities, count } = await cascadingScan( | ||
| "nmap-dummy-ssh", | ||
| "nmap", | ||
| ["-Pn", "-sV", "dummy-ssh.demo-targets.svc"], | ||
| { | ||
| nameCascade: "ncrack-ssh", | ||
| matchLabels: { | ||
| "securecodebox.io/invasive": "invasive", | ||
| "securecodebox.io/intensive": "high", | ||
| }, | ||
| }, | ||
| 120 | ||
| ); | ||
|
|
||
| expect(count).toBe(1); | ||
| expect(categories).toEqual({ | ||
| "Discovered Credentials": 1, | ||
| }); | ||
| expect(severities).toEqual({ | ||
| high: 1, | ||
| }); | ||
| }, | ||
| 3 * 60 * 1000 | ||
| ); |
42 changes: 42 additions & 0 deletions
42
hooks/cascading-scans/integration-tests/cascade-nmap-sslyze.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| // SPDX-FileCopyrightText: the secureCodeBox authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| const { cascadingScan } = require("../../../tests/integration/helpers"); | ||
|
|
||
| jest.retryTimes(3); | ||
|
|
||
| test( | ||
| "Cascading Scan nmap -> sslyze on unsafe-https", | ||
| async () => { | ||
| const { categories, severities, count } = await cascadingScan( | ||
| "nmap-unsafe-https-sslyze", | ||
| "nmap", | ||
| ["-Pn", "-sV", "unsafe-https.demo-targets.svc", "-p", "443"], | ||
| { | ||
| nameCascade: "https-tls-scan", | ||
| matchLabels: { | ||
| "securecodebox.io/invasive": "non-invasive", | ||
| "securecodebox.io/intensive": "light", | ||
| }, | ||
| }, | ||
| 4 * 60 | ||
| ); | ||
|
|
||
| expect(count).toBe(4); | ||
| expect(categories).toMatchInlineSnapshot(` | ||
| Object { | ||
| "Invalid Certificate": 1, | ||
| "Outdated TLS Version": 2, | ||
| "TLS Service Info": 1, | ||
| } | ||
| `); | ||
| expect(severities).toMatchInlineSnapshot(` | ||
| Object { | ||
| "informational": 1, | ||
| "medium": 3, | ||
| } | ||
| `); | ||
| }, | ||
| 5 * 60 * 1000 | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the
|here? Never seen this before and I'm too stupid to google it...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second question: What does the 2 mean in the target name? We should avoid magic numbers in names.