Use matrix in ci for hook integration-test#1035
Merged
Weltraumschaf merged 15 commits intomainfrom Mar 23, 2022
Merged
Conversation
also disables the tests found in test/integration since they will be removed anyway at a later date Signed-off-by: Rami Souai <[email protected]>
RamiSouai
added
maintenance
testing
Signed-off-by: Rami Souai <[email protected]>
…n-tests-ci Signed-off-by: Rami Souai <[email protected]>
Signed-off-by: Rami Souai <[email protected]>
Signed-off-by: Rami Souai <[email protected]>
Signed-off-by: Rami Souai <[email protected]>
Signed-off-by: Rami Souai <[email protected]>
Signed-off-by: Rami Souai <[email protected]>
Signed-off-by: Rami Souai <[email protected]>
Only needed for release, and already present in release-build.yml Signed-off-by: Rami Souai <[email protected]>
Signed-off-by: Rami Souai <[email protected]>
The test is only enabled in a nightly build The image is no longer pushed to dockerhub, instead uses the makefile CI just like the other scanners Signed-off-by: Ilyes Ben Dlala <[email protected]>
It instead uses the parser sdk artifact provide by the previous steps Signed-off-by: Ilyes Ben Dlala <[email protected]>
Ilyesbdlala
approved these changes
Mar 23, 2022
Member
Ilyesbdlala
left a comment
Ilyesbdlala
left a comment
There was a problem hiding this comment.
Added some changes: Re-added zap advanced integration test, and using parser SDK Github artefact instead of building them again (optimization).
Weltraumschaf
deleted the
maintenance/use-makefile-for-hook-integration-tests-ci
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #965
Signed-off-by: Rami Souai [email protected]
Description
Add hook integration-tests to the ci Pipeline using makefiles
make integration-testsAlso removes the tests in ./tests/integration from the pipeline (ReadOnly Hook, ReadAndWrite Hook) which will be deleted anyway at a later date.
Zap-advanced integration test is moved to its own job, and is , as always, run only in the nightly build
#1028 is required for the pipeline to run properly in this branch
Checklist
npm testruns for the whole project.