#1399: Use specific rule in semgrep integration-test instead of ruleset#1400
Merged
Weltraumschaf merged 1 commit intomainfrom Oct 11, 2022
Merged
#1399: Use specific rule in semgrep integration-test instead of ruleset#1400Weltraumschaf merged 1 commit intomainfrom
Weltraumschaf merged 1 commit intomainfrom
Conversation
Signed-off-by: Rami Souai <[email protected]>
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| eslint | 1 | 1 | 0.86s | ||
| ✅ SPELL | misspell | 1 | 0 | 0.05s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
Weltraumschaf
requested review from
Weltraumschaf
and removed request for
malexmave
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rami Souai [email protected]
Fixes #1399
This PR solves the issue by scanning for the specific rule (command-injection-os-system) found in the vulnerable python test file in the Semgrep integraiton-test scan, instead of an entire ruleset.
Rulesets are subject to change and can have rules removed or added, leading to more or less vulnerabilties found during the test process and making assertions in those tests difficult to maintain.
Description
Checklist