Conversation
dependabot
bot
added
dependencies
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Weltraumschaf
force-pushed
the
dependabot/npm_and_yarn/documentation/npm-version-updates-b86a8bda1f
branch
from
7e18c47 to
921cba4
Compare
Weltraumschaf
approved these changes
Jan 14, 2025
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports
|
J12934
requested changes
Jan 14, 2025
Member
J12934
left a comment
J12934
left a comment
There was a problem hiding this comment.
doesn't work. react accordion pacakge that we have doesn't work with react 19
Member
|
https://www.npmjs.com/package/react-accessible-accordion only seems to be used for 3 tiny accordions on the main https://www.securecodebox.io site. I'd be fine with dropping them as accordions and just always showing the entire text. |
Weltraumschaf
force-pushed
the
dependabot/npm_and_yarn/documentation/npm-version-updates-b86a8bda1f
branch
from
921cba4 to
c06cef8
Compare
Member
Created Issue to remove the accordeon. |
J12934
requested changes
Jan 28, 2025
| {items.map((item, i) => { | ||
| const isExpanded = (expandedIndex === i); | ||
| return ( | ||
| <div |
Member
There was a problem hiding this comment.
cool :)
can you change this element to be a button?
having this just be a div would other wise probably not be properly interactable for people with screen readers.
Ilyesbdlala
force-pushed
the
dependabot/npm_and_yarn/documentation/npm-version-updates-b86a8bda1f
branch
from
bcf8140 to
5cb44f3
Compare
Bumps the npm-version-updates group with 10 updates in the /documentation directory: | Package | From | To | | --- | --- | --- | | [@docusaurus/core](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus) | `3.6.3` | `3.7.0` | | [@docusaurus/preset-classic](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-preset-classic) | `3.6.3` | `3.7.0` | | [@docusaurus/theme-live-codeblock](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-theme-live-codeblock) | `3.6.3` | `3.7.0` | | [react](https://github.com/facebook/react/tree/HEAD/packages/react) | `18.3.1` | `19.0.0` | | [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) | `18.3.12` | `19.0.6` | | [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) | `18.3.1` | `19.0.0` | | [sass](https://github.com/sass/dart-sass) | `1.83.0` | `1.83.1` | | [@docusaurus/tsconfig](https://github.com/facebook/docusaurus/tree/HEAD/packages/docusaurus-tsconfig) | `3.6.3` | `3.7.0` | | [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) | `22.10.2` | `22.10.5` | | [typescript](https://github.com/microsoft/TypeScript) | `5.7.2` | `5.7.3` | Updates `@docusaurus/core` from 3.6.3 to 3.7.0 - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v3.7.0/packages/docusaurus) Updates `@docusaurus/preset-classic` from 3.6.3 to 3.7.0 - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v3.7.0/packages/docusaurus-preset-classic) Updates `@docusaurus/theme-live-codeblock` from 3.6.3 to 3.7.0 - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v3.7.0/packages/docusaurus-theme-live-codeblock) Updates `react` from 18.3.1 to 19.0.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.0.0/packages/react) Updates `@types/react` from 18.3.12 to 19.0.6 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) Updates `react-dom` from 18.3.1 to 19.0.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.0.0/packages/react-dom) Updates `sass` from 1.83.0 to 1.83.1 - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.83.0...1.83.1) Updates `@docusaurus/module-type-aliases` from 3.6.3 to 3.7.0 - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v3.7.0/packages/docusaurus-module-type-aliases) Updates `@docusaurus/tsconfig` from 3.6.3 to 3.7.0 - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v3.7.0/packages/docusaurus-tsconfig) Updates `@docusaurus/types` from 3.6.3 to 3.7.0 - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v3.7.0/packages/docusaurus-types) Updates `@types/node` from 22.10.2 to 22.10.5 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `@types/react` from 18.3.12 to 19.0.6 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) Updates `typescript` from 5.7.2 to 5.7.3 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.7.2...v5.7.3) --- updated-dependencies: - dependency-name: "@docusaurus/core" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm-version-updates - dependency-name: "@docusaurus/preset-classic" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm-version-updates - dependency-name: "@docusaurus/theme-live-codeblock" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: npm-version-updates - dependency-name: react dependency-type: direct:production update-type: version-update:semver-major dependency-group: npm-version-updates - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-version-updates - dependency-name: react-dom dependency-type: direct:production update-type: version-update:semver-major dependency-group: npm-version-updates - dependency-name: sass dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm-version-updates - dependency-name: "@docusaurus/module-type-aliases" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-version-updates - dependency-name: "@docusaurus/tsconfig" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-version-updates - dependency-name: "@docusaurus/types" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-version-updates - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-version-updates - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-version-updates - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-version-updates ... Signed-off-by: dependabot[bot] <[email protected]>
…-accordion it nows uses a very simple toggle functionality that fits our use-case Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Ilyesbdlala
force-pushed
the
dependabot/npm_and_yarn/documentation/npm-version-updates-b86a8bda1f
branch
from
5cb44f3 to
47b725d
Compare
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
|
J12934
approved these changes
Jan 31, 2025
J12934
deleted the
dependabot/npm_and_yarn/documentation/npm-version-updates-b86a8bda1f
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the npm-version-updates group with 10 updates in the /documentation directory:
3.6.33.7.03.6.33.7.03.6.33.7.018.3.119.0.018.3.1219.0.618.3.119.0.01.83.01.83.13.6.33.7.022.10.222.10.55.7.25.7.3Updates
@docusaurus/corefrom 3.6.3 to 3.7.0Release notes
Sourced from
@docusaurus/core's releases.... (truncated)
Changelog
Sourced from
@docusaurus/core's changelog.... (truncated)
Commits
dd59750v3.7.0cacb973feat(core): Turn Rspack incremental on by default (again) (#10800)e7a8c9drefactor(core): Use Intl native API to get locale direction, remove rtl-detec...0f29a37feat: Add React 19 support to Docusaurus v3 (#10763)4966dcerefactor(core): swizzle wrap should use ReactNode instead of JSX.Element (#10...f9825afrefactor: prepare types for React 19 (#10746)df6f53afeat(svgr): create new Docusaurus SVGR plugin (#10677)8098741fix(core): fix codegen routesChunkName possible hash collision (#10727)fd43036chore: release Docusaurus 3.6.3 (#10713)Updates
@docusaurus/preset-classicfrom 3.6.3 to 3.7.0Release notes
Sourced from
@docusaurus/preset-classic's releases.... (truncated)
Changelog
Sourced from
@docusaurus/preset-classic's changelog.... (truncated)
Commits
dd59750v3.7.00f29a37feat: Add React 19 support to Docusaurus v3 (#10763)df6f53afeat(svgr): create new Docusaurus SVGR plugin (#10677)fd43036chore: release Docusaurus 3.6.3 (#10713)Updates
@docusaurus/theme-live-codeblockfrom 3.6.3 to 3.7.0Release notes
Sourced from
@docusaurus/theme-live-codeblock's releases.... (truncated)
Changelog
Sourced from
@docusaurus/theme-live-codeblock's changelog.... (truncated)
Commits
dd59750v3.7.00f29a37feat: Add React 19 support to Docusaurus v3 (#10763)f9825afrefactor: prepare types for React 19 (#10746)fd43036chore: release Docusaurus 3.6.3 (#10713)Updates
reactfrom 18.3.1 to 19.0.0Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.