#2680 Grant delete permissions for scheduled scans in auto-discovery#2871
Merged
J12934 merged 3 commits intosecureCodeBox:mainfrom Jan 28, 2025
Merged
Conversation
…to-discovery Add missing delete permissions for ScheduledScans in auto-discovery. Update `.helmignore` to exclude unused files, reducing Helm container size for local deployments. Signed-off-by: Boris Shek <[email protected]>
✅ Deploy Preview for docs-securecodebox canceled.
|
Signed-off-by: Boris Shek <[email protected]>
…scovery Previously, the Container Auto-Discovery controller logged an error when trying to fetch a ScheduledScan that was already deleted. This change introduces a check for `IsNotFound` errors, treating them as expected behavior instead of logging them as errors. Now, if a ScheduledScan is not found, an informational log message is recorded instead of an error. This prevents unnecessary noise in logs. Signed-off-by: Boris Shek <[email protected]>
|
J12934
approved these changes
Jan 28, 2025
Contributor
Author
|
Resolves #2680 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing delete permissions for ScheduledScans in auto-discovery. Update
.helmignoreto exclude unused files, reducing Helm container size for local deployments.Description
Checklist