Rewrite git-repo-scanner in Go#3392
Merged
J12934 merged 9 commits intosecureCodeBox:mainfrom Dec 15, 2025
Merged
Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
J12934
requested changes
Dec 1, 2025
Member
J12934
left a comment
J12934
left a comment
There was a problem hiding this comment.
Only had a short look over the general structure of the go code looked good to me so far :)
@p4trickweiss can you have a look at the sonar results?
The function length / cyclometic complexity thingies i think aren't too bad, can be ignoried I'd say. Also the function arg one looks ok for me in this case.
But the naming stuff I'd suggest to change as this is a general golang code style thing, also the context on the struct.
Another thing: can you make sure that the golang tests are also executed in the CI?
ideally also with that go staticcheck tool that we are also using for the operator and such.
scanners/git-repo-scanner/examples/github-secureCodeBox-scan/scan.yaml
Outdated
Show resolved
Hide resolved
p4trickweiss
force-pushed
the
git-repo-scanner
branch
from
c03bc5b to
7fe69fe
Compare
J12934
approved these changes
Dec 15, 2025
github-project-automation
bot
moved this from To Review
to Reviewer Approved
in secureCodeBox
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
p4trickweiss
force-pushed
the
git-repo-scanner
branch
from
fad08af to
3fdaef4
Compare
github-project-automation
bot
moved this from Reviewer Approved
to Done
in secureCodeBox
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(closes #3378)
Checklist