Skip to content

Fix Bug with Subfinder Parser includeTargetDomain flag for empty results#3506

Merged
J12934 merged 3 commits intosecureCodeBox:mainfrom
J12934:bugfix/empty-subfinder-results
Feb 10, 2026
Merged

Fix Bug with Subfinder Parser includeTargetDomain flag for empty results#3506
J12934 merged 3 commits intosecureCodeBox:mainfrom
J12934:bugfix/empty-subfinder-results

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Feb 10, 2026

Description

Our subfinder parser is crashing when it has empty results.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Makes it easier to understand what this bool flag is doing from the tests

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 requested a review from p4trickweiss February 10, 2026 09:05
@J12934 J12934 self-assigned this Feb 10, 2026
@J12934 J12934 added the bug Bugs label Feb 10, 2026
@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit aaf3b06
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/698af4e1acfca2000828c6a5

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
24.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@github-project-automation github-project-automation bot moved this from Triage to Reviewer Approved in secureCodeBox Feb 10, 2026
@J12934 J12934 merged commit 1535335 into secureCodeBox:main Feb 10, 2026
48 of 50 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in secureCodeBox Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants

Comments