Skip to content

Comments

Fixed HelmChart Hook Templates#367

Merged
rfelber merged 1 commit intomainfrom
feature/fixing-hooks-helmchart-names
Apr 12, 2021
Merged

Fixed HelmChart Hook Templates#367
rfelber merged 1 commit intomainfrom
feature/fixing-hooks-helmchart-names

Conversation

@rfelber
Copy link
Member

@rfelber rfelber commented Apr 12, 2021

Description

Fixed HelmChart Hook templates to use the correct chart name and labels. Otherwise this could lead to errors when GitOps tools like ArgoCD or FluxCD are used to install the secureCodeBox.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@rfelber rfelber added the bug Bugs label Apr 12, 2021
@rfelber rfelber added this to the v2.6.0 milestone Apr 12, 2021
@rfelber rfelber requested a review from J12934 April 12, 2021 10:45
@rfelber rfelber self-assigned this Apr 12, 2021
@rfelber rfelber enabled auto-merge April 12, 2021 10:58
@rfelber rfelber merged commit 1f26c9f into main Apr 12, 2021
@rfelber rfelber deleted the feature/fixing-hooks-helmchart-names branch April 12, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants