Skip to content

Comments

Introduce Testing Makefiles For Amass Scanner And Finding Post Processing Hook#494

Closed
nigthknight wants to merge 86 commits intomainfrom
maintenance/scanner-makefiles
Closed

Introduce Testing Makefiles For Amass Scanner And Finding Post Processing Hook#494
nigthknight wants to merge 86 commits intomainfrom
maintenance/scanner-makefiles

Conversation

@nigthknight
Copy link
Member

@nigthknight nigthknight commented Jun 14, 2021

Because This PR became so bloated, I decided to split this PR into multiple PRs

See: #476

@nigthknight nigthknight added ci Changes to the continuous integration setup enhancement New feature or request maintenance testing Improvements or additions regarding the test setup labels Jun 14, 2021
@nigthknight nigthknight self-assigned this Jun 14, 2021
@nigthknight nigthknight force-pushed the maintenance/scanner-makefiles branch 2 times, most recently from 1d9dad6 to c4794c7 Compare June 14, 2021 11:53
@nigthknight nigthknight force-pushed the maintenance/scanner-makefiles branch 3 times, most recently from 6986322 to 8ff78f9 Compare June 15, 2021 10:02
@nigthknight nigthknight requested a review from J12934 June 15, 2021 10:31
@rfelber rfelber added this to the v3.0.0 milestone Jun 18, 2021
@nigthknight nigthknight force-pushed the maintenance/scanner-makefiles branch 11 times, most recently from fc25992 to a481590 Compare June 28, 2021 12:27
@nigthknight nigthknight marked this pull request as ready for review June 28, 2021 12:27
@nigthknight nigthknight requested a review from rfelber June 29, 2021 06:16
//
// SPDX-License-Identifier: Apache-2.0

const { scan } = require("../helpers");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this file be deleted?

@J12934
Copy link
Member

J12934 commented Jun 29, 2021

The PR title is now pretty misleading as this does very little to scanners but quite a lot to hooks 😜

Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
To improve testing I added some additional steps to automatically build
and import the container images for operator and lurker

Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
I changed the Pull Policy to `IfNotPresent` to avoid unnecessary
rebuilds of the operator image

Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
@nigthknight nigthknight force-pushed the maintenance/scanner-makefiles branch from f9c32a9 to e3af860 Compare July 19, 2021 06:30
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Yannik Fuhrmeister <[email protected]>
@nigthknight nigthknight force-pushed the maintenance/scanner-makefiles branch 2 times, most recently from f3e1a34 to 71f367c Compare July 19, 2021 07:00
@nigthknight
Copy link
Member Author

nigthknight commented Jul 20, 2021

Because This PR became so bloated, I decided to split this PR into multiple PRs

@rfelber rfelber deleted the maintenance/scanner-makefiles branch August 8, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Changes to the continuous integration setup enhancement New feature or request maintenance testing Improvements or additions regarding the test setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align Hook Directory Structure With Scanner

3 participants