Skip to content

Comments

Remove ssh_scan Workaround#517

Merged
nigthknight merged 2 commits intomainfrom
maintenance/cleanup-ssh-scan
Jun 22, 2021
Merged

Remove ssh_scan Workaround#517
nigthknight merged 2 commits intomainfrom
maintenance/cleanup-ssh-scan

Conversation

@twwd
Copy link
Contributor

@twwd twwd commented Jun 22, 2021

Description

Removes the workaround that replaced the _ with - for ssh-scan
when using it with helm.

Closes #180

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

twwd added 2 commits June 22, 2021 15:20
Removes the workaround that replaced the `_` with `-` for `ssh-scan`
when using it with helm.

Signed-off-by: Tim Walter <[email protected]>
Renames remaining references of the demo-apps to demo-targets.

Signed-off-by: Tim Walter <[email protected]>
@twwd twwd requested a review from nigthknight June 22, 2021 13:26
@twwd twwd self-assigned this Jun 22, 2021
@nigthknight nigthknight enabled auto-merge June 22, 2021 13:30
@nigthknight nigthknight merged commit c116623 into main Jun 22, 2021
@nigthknight nigthknight deleted the maintenance/cleanup-ssh-scan branch June 22, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent directory labeling for "ssh_scan"

2 participants