Skip to content

Comments

Add Alert Filters Config to ZAP Advanced#562

Merged
rfelber merged 9 commits intomainfrom
feature/zap-advanced-alert-filters
Jul 30, 2021
Merged

Add Alert Filters Config to ZAP Advanced#562
rfelber merged 9 commits intomainfrom
feature/zap-advanced-alert-filters

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Jul 26, 2021

Description

This PR adds config option to configure context based alert filters in Zap Advanced Scans.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

J12934 added 8 commits July 26, 2021 14:12
@J12934
Add option to add alert filters for contexts
ceba506 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Fix init of empty collection if no matcher is configured
8fbc3f7 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Tweak log levels
9526b23 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Add intergration test for alertFilters
6d3519f 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Log out integer directly
2a70f95 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Remove purly debugging logs
d6e7816 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Passing None as acutal nones instead of a stringified 'None'
6c37314 
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934
Add null & sanity check for helper method to better catch empty like …
45738f1 
…values

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 added enhancement New feature or request scanner Implement or update a security scanner labels Jul 26, 2021
@J12934 J12934 requested a review from rfelber July 26, 2021 12:13
@J12934 J12934 self-assigned this Jul 26, 2021
@J12934
Copy link
Member Author

J12934 commented Jul 26, 2021

Fixing the issues left in code climate would make the code worse in my opinion.
Especially the return statements rule feels wrong.

rfelber
rfelber approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@rfelber rfelber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@rfelber rfelber merged commit d5cfd57 into main Jul 30, 2021
@rfelber rfelber deleted the feature/zap-advanced-alert-filters branch July 30, 2021 10:04
@rfelber rfelber mentioned this pull request Apr 9, 2023
Closed
This was referenced Apr 9, 2023
Open
Open
Open
Open
@rfelber rfelber mentioned this pull request Apr 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rfelber rfelber rfelber approved these changes

@nigthknight nigthknight nigthknight approved these changes

Assignees

@J12934 J12934

Labels

enhancement New feature or request scanner Implement or update a security scanner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@J12934 @rfelber @nigthknight