Skip to content

Comments

Integrating new scanner Whatweb to the secureCodeBox (closes #567)#592

Merged
Weltraumschaf merged 56 commits intomainfrom
scanner/whatweb
Sep 1, 2021
Merged

Integrating new scanner Whatweb to the secureCodeBox (closes #567)#592
Weltraumschaf merged 56 commits intomainfrom
scanner/whatweb

Conversation

@SebieF
Copy link
Contributor

@SebieF SebieF commented Aug 11, 2021

Description

This PR adds the new fingerprinting scanner Whatweb to the scb. It identifies websites and recognizes used technology. This can be especially useful for cascading scans.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

(closes #567)

@SebieF SebieF added scanner Implement or update a security scanner testing Improvements or additions regarding the test setup labels Aug 11, 2021
@SebieF SebieF self-assigned this Aug 11, 2021
J12934 and others added 21 commits August 11, 2021 20:18
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Sebastian <[email protected]>
…Dojo

DefectDojo apparently now validates that these are in the right format, nice 👍

Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Adding securecodebox.io

Signed-off-by: Sebastian <[email protected]>
Scan type, Parse definition, Cascading rules

Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Basic scanning of example.com and check for invalid argument

Signed-off-by: Sebastian <[email protected]>
Adding parser, scanner and integration test

Signed-off-by: Sebastian <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: Sebastian <[email protected]>
SebieF added 4 commits August 25, 2021 10:43
Making codeclimate happy

Signed-off-by: Sebastian <[email protected]>
At least I tried

Signed-off-by: Sebastian <[email protected]>
@SebieF SebieF marked this pull request as ready for review August 25, 2021 14:34
Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍
Only some small things, other than that, the PR should be ready to be merged

SebieF and others added 10 commits August 28, 2021 16:43
Parser has no dependencies

Signed-off-by: Sebastian <[email protected]>
Removed package.json dependencies

Signed-off-by: Sebastian <[email protected]>
Now using ruby image, installing whatweb manually via make. Upgrades from version 0.4.9 on Debian to 0.5.5

Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Failing integration tests otherwise

Signed-off-by: Sebastian <[email protected]>
@SebieF SebieF requested a review from J12934 August 28, 2021 16:12
rfelber
rfelber previously approved these changes Aug 31, 2021
@rfelber
Copy link
Member

rfelber commented Aug 31, 2021

Hi @SebieF,
Great work 👍
One thing last: your PR has a conflict that needs to be solved... than the PR should be ready to be merged

Signed-off-by: Sebastian <[email protected]>

Co-authored-by: Robert Seedorff <[email protected]>
@Weltraumschaf Weltraumschaf merged commit eddd469 into main Sep 1, 2021
@Weltraumschaf Weltraumschaf deleted the scanner/whatweb branch September 1, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scanner Implement or update a security scanner testing Improvements or additions regarding the test setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add WhatWeb as new scanner for fingerprinting usecases

4 participants