DefectDojo Hook Tests now pass on any OS#596
Closed
JohannesZahn wants to merge 2 commits intomainfrom
Closed
Conversation
Signed-off-by: Johannes Zahn <[email protected]>
JohannesZahn
changed the title
JohannesZahn
changed the title
Signed-off-by: Johannes Zahn <[email protected]>
Member
|
Could we remove the Json assert Lib by parsing the Json into our Finding Class and running the assertions on these? |
Contributor
Author
|
It should be possible unless Jackson changes the order of the list which I am not completly sure on right now. I am also not sure if we should then use Jacksons ObjectNode.equals() on the JSON Findings or rely on a custom/lombok generated Equals methods on the Objects themselves. The second approach would look somewhat like this DefectDojoImportFinding[] expectedDDFindings = jsonMapper.readValue(ddFindingsUrl, DefectDojoImportFinding[].class);
DefectDojoImportFinding[] actualDdFindings = jsonMapper.readValue(actualDdFindingsString, DefectDojoImportFinding[].class);
assertArrayEquals(expectedDDFindings,actualDdFindings); |
Contributor
Author
|
This moved to #600 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unit Tests on Windows failed even though they were supposed to pass. This was due asserting JSON Objects as equal that contained different line breaks. This was fixed by using the Library JSONAssert.
Checklist
npm testruns for the whole project.