Skip to content

Comments

Bugfixed zap-advanced HelmChart to Include the Authentication Scripts Again#597

Merged
rfelber merged 2 commits intomainfrom
fix/missing-zap-charts
Aug 16, 2021
Merged

Bugfixed zap-advanced HelmChart to Include the Authentication Scripts Again#597
rfelber merged 2 commits intomainfrom
fix/missing-zap-charts

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Aug 12, 2021

This caused the configmaps to contain no scripts, as they were ignored from the charts :(

This cas caused the configmaps to contain a empty list of scripts as the scipts weren't included in the chart anymore :(

Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 added the bug Bugs label Aug 12, 2021
@J12934 J12934 requested a review from rfelber August 12, 2021 17:10
@J12934 J12934 self-assigned this Aug 12, 2021
Signed-off-by: Jannik Hollenbach <[email protected]>
@J12934 J12934 force-pushed the fix/missing-zap-charts branch from 2789aa6 to e2e2424 Compare August 16, 2021 08:34
@J12934 J12934 requested a review from rfelber August 16, 2021 12:12
@rfelber rfelber merged commit d50c3c3 into main Aug 16, 2021
@rfelber rfelber deleted the fix/missing-zap-charts branch August 16, 2021 21:09
@rfelber rfelber linked an issue Aug 31, 2021 that may be closed by this pull request
@rfelber rfelber added the scanner Implement or update a security scanner label Aug 31, 2021
@rfelber rfelber changed the title Revert Change in Helmignore to Include the Scripts Again Bugfixed zap-advanced HelmChart to Include the Authentication Scripts Again Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs scanner Implement or update a security scanner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authenticated advanced ZAP scan fails in the Juice Shop demo

2 participants