Skip to content

Comments

Ensure Findings are validated in Integration Tests (closes #546)#603

Merged
Weltraumschaf merged 12 commits intomainfrom
feature/validate-findings-integration-tests
Aug 31, 2021
Merged

Ensure Findings are validated in Integration Tests (closes #546)#603
Weltraumschaf merged 12 commits intomainfrom
feature/validate-findings-integration-tests

Conversation

@JohannesZahn
Copy link
Contributor

@JohannesZahn JohannesZahn commented Aug 20, 2021 •
edited
Loading

Description

The recently introduced Finding Validation should also be applied in the integration tests.
This can simply be implemented by setting an environment variable which is evaluated in the parser sdk and makes the scanner crash if the findings are invalid.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@JohannesZahn JohannesZahn self-assigned this Aug 23, 2021
@JohannesZahn JohannesZahn added the testing Improvements or additions regarding the test setup label Aug 23, 2021
@JohannesZahn
use test scan to make sure invalid findings make tests fail
6145e05 
Signed-off-by: Johannes Zahn <[email protected]>
@JohannesZahn
fix code climate issues
0d67530 
Signed-off-by: Johannes Zahn <[email protected]>
@JohannesZahn
copy findings schema to docker container
ea448d2 
Signed-off-by: Johannes Zahn <[email protected]>
@JohannesZahn
validate the findings with ids and dates
858d89c 
Signed-off-by: Johannes Zahn <[email protected]>
@JohannesZahn
validate findings in all tests where scans are involved
0722646 
Signed-off-by: Johannes Zahn <[email protected]>
@JohannesZahn
fix string formatting issues
33e0047 
Signed-off-by: Johannes Zahn <[email protected]>
@JohannesZahn
fix bug with invalid findings in test-scann
56ab4c8 
Signed-off-by: Johannes Zahn <[email protected]>
@JohannesZahn
fix bug due to naming error
cb1d9ce 
Signed-off-by: Johannes Zahn <[email protected]>
@JohannesZahn JohannesZahn marked this pull request as ready for review August 24, 2021 06:13
@JohannesZahn JohannesZahn changed the title Finding Validation in Integration Tests Finding are validation in Integration Tests Aug 24, 2021
@JohannesZahn JohannesZahn changed the title Finding are validation in Integration Tests Finding are validated in Integration Tests Aug 24, 2021
@JohannesZahn JohannesZahn requested a review from rfelber August 31, 2021 08:43
@rfelber rfelber linked an issue Aug 31, 2021 that may be closed by this pull request
Authenticated advanced ZAP scan fails in the Juice Shop demo #615
Closed
Weltraumschaf
Weltraumschaf approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@Weltraumschaf Weltraumschaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Weltraumschaf Weltraumschaf merged commit e133586 into main Aug 31, 2021
@Weltraumschaf Weltraumschaf deleted the feature/validate-findings-integration-tests branch August 31, 2021 11:37
@rfelber rfelber linked an issue Aug 31, 2021 that may be closed by this pull request
Validate Findings in Integration Tests #546
Closed
@rfelber rfelber changed the title Finding are validated in Integration Tests Ensure Findings are validated in Integration Tests (closes #546) Aug 31, 2021
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Merged
@rfelber rfelber mentioned this pull request Apr 9, 2023
Closed
This was referenced Apr 9, 2023
Open
Open
This was referenced Apr 10, 2023
Open
Open
@rfelber rfelber mentioned this pull request Apr 10, 2023
Merged
This was referenced Jun 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Weltraumschaf Weltraumschaf Weltraumschaf approved these changes

@nigthknight nigthknight Awaiting requested review from nigthknight

@J12934 J12934 Awaiting requested review from J12934

@rfelber rfelber Awaiting requested review from rfelber

Assignees

@JohannesZahn JohannesZahn

Labels

testing Improvements or additions regarding the test setup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Authenticated advanced ZAP scan fails in the Juice Shop demo Validate Findings in Integration Tests

2 participants

@JohannesZahn @Weltraumschaf