Conversation
No pun intended Signed-off-by: Sebastian <[email protected]>
Replacing
ttlSecondsAfterFinished: {{ .Values.parser.ttlSecondsAfterFinished }} with
ttlSecondsAfterFinished: {{ .Values.parser.image.ttlSecondsAfterFinished }}
Signed-off-by: Sebastian <[email protected]>
Member
|
+1 for consistency. But placing the ttl after finished would be conceptually wrong for me, as the ttl has nothing to do with the image, but the kubernetes job created by the parseDefinitions. I think it is fine where it it. |
Replacing
ttlSecondsAfterFinished: {{ .Values.parser.image.ttlSecondsAfterFinished }} with
ttlSecondsAfterFinished: {{ .Values.parser.ttlSecondsAfterFinished }}
Signed-off-by: Sebastian <[email protected]>
Contributor
Author
Fair point, wasn't sure about that. In hindsight, I think only ncrack used this .image. so it makes more sense to adjust that. |
Because of failing ci pipeline integration tests Signed-off-by: Sebastian <[email protected]>
This reverts commit 2371720. Signed-off-by: Sebastian <[email protected]>
SebieF
force-pushed
the
fixing-parse-definitions-inconsistencies
branch
from
0f766ec to
b5b16d6
Compare
rfelber
approved these changes
Aug 31, 2021
rfelber
changed the title
rfelber
added
bug
rfelber
changed the title
rfelber
changed the title
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had a lot of new scanner pull requests recently, that's why I came to think about code/file consistency for our scanners. I think it is worth discussing this topic publicly or in our retro, because it makes our code more maintainable and easier to understand.
For now, I only fixed some small inconsistencies and a typo for templates/scanner-name-parse-definition.yaml.