Introduce Makefile For All Scanners & Hooks#622
Introduce Makefile For All Scanners & Hooks#622J12934 merged 28 commits intosecureCodeBox:mainfrom EndPositive:makefile-scanners
Conversation
EndPositive
changed the title
|
Awesome work, yeah good idea to keep the Makefile and pipeline changes seperate for now to not block releases. |
J12934
added
architecture
|
I'm planning to finish this during the weekend and I'll tag you for a review on/before Monday! Although not necessary for this PR, it would be really nice if you could take a look at #610. |
|
Awesome 👏 Plan for #610 is to migrate the Nikto image to be "docker build'able" just like the other 3rd party scanners. Until then wen can just pin the Nikto image used for the integration tests to 2.1.6. |
|
@J12934 I think that should do it. Could you take a look and make changes wherever neccessary? |
|
Yes 👍 |
|
@J12934 awesome, thank you for the fixes! 👏 The Makefile for Nikto is still missing, but we can fix that once its version is pinned. Another thing I wanted to mention is the integration tests for cascading scans. Currently they are set up in a manner that requires them to run separately (due to different scanner installs; i.e. ncrack vs sslyze). If you look at the Makefile for cascading scans, you'll notice there's also a test-2 target. With this setup, that test-2 won't run in a matrix job. Did you have any thoughts on that? Besides that, I think it's ready to be merged. It's bound to have issues, but let's give it a shot. It's only for development purposes currently anyways. I'll take a look at updating the integration tests documentation coming week. |
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
… makefile) Signed-off-by: Jop Zitman <[email protected]>
…ring all generic integration tests) Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
…o the integration-tests namespace Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
…st suites Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
Required for hook integration tests, as the require ts-jest to be installed Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Signed-off-by: Jannik Hollenbach <[email protected]>
Integration-Tests should be executed using the Makefile structure to install all needed dependencies Signed-off-by: Yannik Fuhrmeister <[email protected]>
Signed-off-by: Jop Zitman <[email protected]>
3 participants
Description
This PR continues the effort of #601, however only applies changes unrelated to the pipeline. This makes intermediate merging, reviewing and testing easier.
This PR does NOT break the current pipeline and works as is locally.
This PR contains the following changes
Checklist
npm testruns for the whole project.