Skip to content

Comments

Add integration tests to Typo3Scan #647

Merged
J12934 merged 8 commits intomainfrom
feature/add-typo3-integration-test
Sep 17, 2021
Merged

Add integration tests to Typo3Scan #647
J12934 merged 8 commits intomainfrom
feature/add-typo3-integration-test

Conversation

@Ilyesbdlala
Copy link
Member

Description

This PR uses the new old-typo3 demo-target to implement Integration tests for the Typo3Scan Scanner in The CI.
The demo-target old-typo3 is also built within the CI.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

The demo-target build is also added

Signed-off-by: Ilyes Ben Dlala <[email protected]>
This is to allow binding to port 80 from kind cluster

Signed-off-by: Ilyes Ben Dlala <[email protected]>
Updated Test Snapshot

Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Resolved conflict .github/workflows/ci.yaml
Signed-off-by: Ilyes Ben Dlala <[email protected]>
@Ilyesbdlala Ilyesbdlala added scanner Implement or update a security scanner testing Improvements or additions regarding the test setup labels Sep 15, 2021
@Ilyesbdlala Ilyesbdlala self-assigned this Sep 15, 2021
And Better typo3scan test description

Signed-off-by: Ilyes Ben Dlala <[email protected]>
@Ilyesbdlala Ilyesbdlala mentioned this pull request Sep 15, 2021
3 tasks
@J12934 J12934 merged commit d0e3e03 into main Sep 17, 2021
@J12934 J12934 deleted the feature/add-typo3-integration-test branch September 17, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scanner Implement or update a security scanner testing Improvements or additions regarding the test setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants