Merged
Conversation
Signed-off-by: Ilyes Ben Dlala <[email protected]>
The demo-target build is also added Signed-off-by: Ilyes Ben Dlala <[email protected]>
This is to allow binding to port 80 from kind cluster Signed-off-by: Ilyes Ben Dlala <[email protected]>
Updated Test Snapshot Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Resolved conflict .github/workflows/ci.yaml Signed-off-by: Ilyes Ben Dlala <[email protected]>
And Better typo3scan test description Signed-off-by: Ilyes Ben Dlala <[email protected]>
3 tasks
J12934
approved these changes
Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the new old-typo3 demo-target to implement Integration tests for the Typo3Scan Scanner in The CI.
The demo-target old-typo3 is also built within the CI.
Checklist
npm testruns for the whole project.