Conversation
Start of implementation of Joomla scanner CMSeeK into secureCodebox Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
related wrapper.sh is also added. This file is added to move the scanner's results to a known location. Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
wrapper.sh checks if finding result file exists Signed-off-by: Ilyes Ben Dlala <[email protected]>
Dockerfile, parser.js and test files Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
This is done to fix the CI and use the new Makefiles
Signed-off-by: GitHub Actions <[email protected]>
This is done to make codeclimate happy Signed-off-by: Ilyes Ben Dlala <[email protected]>
This is done to make codeclimate happy Signed-off-by: Ilyes Ben Dlala <[email protected]>
11 tasks
Fix typo in cmseek-scan-type.yaml Signed-off-by: Ilyes Ben Dlala <[email protected]>
rfelber
reviewed
Sep 22, 2021
rfelber
reviewed
Sep 22, 2021
rfelber
reviewed
Sep 22, 2021
rfelber
reviewed
Sep 22, 2021
rfelber
reviewed
Sep 22, 2021
rfelber
reviewed
Sep 22, 2021
rfelber
reviewed
Sep 22, 2021
rfelber
reviewed
Sep 22, 2021
rfelber
reviewed
Sep 22, 2021
rfelber
reviewed
Sep 22, 2021
rfelber
previously requested changes
Sep 22, 2021
Member
rfelber
left a comment
rfelber
left a comment
There was a problem hiding this comment.
Great Work @Ilyesbdlala 🙌 🎉
I added some hints for improvements even if this PR is in a early draft stage 👍🏻
according to suggestions from code review Signed-off-by: Ilyes Ben Dlala <[email protected]> Co-authored-by: Robert Seedorff <[email protected]> Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: GitHub Actions <[email protected]> Signed-off-by: Ilyes Ben Dlala <[email protected]>
Ilyesbdlala
force-pushed
the
feature/add-scanner-cmseek
branch
from
60ca833 to
2ccd1f7
Compare
This is done to fix the failing trivy integration-test Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Fixed docker entrypoint command to be compatible with helm Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Member
Author
|
The CI Integration tests rely on the old-joomla demo-target #681 to pass. The tests are expected to fail until that PR is merged. |
This is done to fix the CI and allow the CMSeeK integration tests Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
rfelber
approved these changes
Oct 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new Scanner that that scans websites using Joomla content management system: cmseek.
Checklist
npm testruns for the whole project.