Multitude of Makefile and integration test issue and style fixes#688
Merged
nigthknight merged 1 commit intosecureCodeBox:mainfrom Oct 4, 2021
EndPositive:makefile-fixes
Merged
Multitude of Makefile and integration test issue and style fixes#688nigthknight merged 1 commit intosecureCodeBox:mainfrom EndPositive:makefile-fixes
nigthknight merged 1 commit intosecureCodeBox:mainfrom
EndPositive:makefile-fixes
Conversation
Signed-off-by: Jop Zitman <[email protected]>
nigthknight
approved these changes
Oct 4, 2021
Member
nigthknight
left a comment
nigthknight
left a comment
There was a problem hiding this comment.
Looks great. Thank you for fixing/contributing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Multitude of Makefile and integration test issue and style fixes
Checklist
npm testruns for the whole project.