Add presigned head url to scan object#690
Merged
J12934 merged 3 commits intosecureCodeBox:mainfrom Oct 6, 2021
EndPositive:minio-head-url
Merged
Add presigned head url to scan object#690J12934 merged 3 commits intosecureCodeBox:mainfrom EndPositive:minio-head-url
J12934 merged 3 commits intosecureCodeBox:mainfrom
EndPositive:minio-head-url
Conversation
Signed-off-by: Jop Zitman <[email protected]>
J12934
reviewed
Oct 5, 2021
Member
J12934
left a comment
J12934
left a comment
There was a problem hiding this comment.
Okay interesting never had to stream files from S3 (yet). 😀
Nice to have the option now 👍
Just a small copy paste error in the description to make the descriptions match properly.
Co-authored-by: Jannik Hollenbach <[email protected]> Signed-off-by: Jop Zitman <[email protected]>
Contributor
Author
|
One day you will and you'll think of me! Thanks for suggestion 😄 . |
Member
|
CRD's need to be regenerated, they still have the typos in them 😉 |
Signed-off-by: Jop Zitman <[email protected]>
J12934
approved these changes
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR, if applied, adds
findingHeadLinkandrawResultHeadLinkto the scan's status. These links are useful in optimization of external services (or hooks) querying the file. It is especially useful when you would like to use something like a streaming response while retaining original headers (obtained through head link).Checklist
npm testruns for the whole project.