Helm Chart: Juice-Shop - Ingress installation failed because of 'apiVersion not set'#698
Merged
J12934 merged 2 commits intosecureCodeBox:mainfrom Oct 5, 2021
fbuchmeier-abi:main
Merged
Helm Chart: Juice-Shop - Ingress installation failed because of 'apiVersion not set'#698J12934 merged 2 commits intosecureCodeBox:mainfrom fbuchmeier-abi:main
J12934 merged 2 commits intosecureCodeBox:mainfrom
fbuchmeier-abi:main
Conversation
fbuchmeier-abi
changed the title
Member
|
Thanks for your contribution! Would you please be so kind and sign our DCO as described here and amend the sign-of to your commits? |
… set' when installing with 'ingress.enabled=true' Signed-off-by: Florian Buchmeier <[email protected]>
Contributor
Author
|
@fuhrmeistery, thanks for the heads up! I've added the sign-off. Regards, |
Member
|
@fbuchmeier-abi thanks for adding the sign-off. Could you please also add yourself to the contributors list as described here? |
Signed-off-by: Florian Buchmeier <[email protected]>
Contributor
Author
|
@fuhrmeistery well of course, thanks for babysitting me 👍 |
J12934
approved these changes
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When enabling the ingress resource, the first
{-template block would remove the line feeds between theapiVersionand the comments at the beginning of the file, causing theapiVersionto be omitted and the resource from failing to install.Checklist
npm testruns for the whole project.