🚧 [Consistency] Adding empty file handling and test to all parsers#705
Merged
🚧 [Consistency] Adding empty file handling and test to all parsers#705
Conversation
Added empty test files where they were missing Signed-off-by: Sebastian <[email protected]>
Added empty test files where they were missing Signed-off-by: Sebastian <[email protected]>
Check if datatype is string ==> No json data Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Either checking for undefined or if the type is string "[]" (and not an object) Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
J12934
previously approved these changes
Oct 5, 2021
This makes the function shorter and clearer (and codeclimate happy) Signed-off-by: Sebastian <[email protected]>
J12934
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #701.
When applied, all parsers are tested for an empty json file.
Where missing, empty test files have been added, error/empty file handling has been introduced to the parser and jest tests have been created.
Checklist