🚧 [Consistency] Create New Scanner makefile command#706
Merged
nigthknight merged 14 commits intomainfrom Oct 13, 2021
Merged
Conversation
Includes all generic files that we use for the scanners. "New-scanner" gets replaced in the makefile with a provided scanner name. Based on nmap and whatweb directories. Signed-off-by: Sebastian <[email protected]>
The new commands copies all files from the template directory .templates/new-scanner to a new folder with name provided as an argument to the make command (make create-new-scanner NAME=SCANNER-NAME). Replaces every occurence of new-scanner in file contents or names with the provided name Signed-off-by: Sebastian <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Consistency with other files Signed-off-by: Sebastian <[email protected]>
…' into consistency/new-scanner-makefile
…files 1. Replacing array command with list of parameters 2. Replacing incorrect copied "nmap-json" type with "new-scanner-json" Signed-off-by: Sebastian <[email protected]>
# Conflicts: # Makefile
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
SebieF
changed the title
nigthknight
requested changes
Oct 12, 2021
Member
nigthknight
left a comment
nigthknight
left a comment
There was a problem hiding this comment.
Looks great! Just one spelling mistake and some discussable comments :)
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
nigthknight
approved these changes
Oct 12, 2021
This was referenced Oct 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #684.
Once applied, this PR adds a new command "create-new-scanner" to the Makefile. Via "NAME=MY-NEW-SCANNER", a new name can be given. All newly added template files will be copied to a new directory with the provided name and all applicable values will be set to the new scanner name.
Checklist