🚧 [Consistency] Make all files of cmseek follow consistent templates#727
Closed
🚧 [Consistency] Make all files of cmseek follow consistent templates#727
Conversation
1. Replaced some unnecessary comments 2. Added xy.xyz.zxy descriptions to all values 3. Added security context to all scanners 4. Added cascading rules to all scanners (when no cascading rules exist, they are set to false) 5. Changed nuclei image tag from "latest" to "null" 6. Set RunAsNonRoot for whatweb from "false" to "true" 7. ncrack, zap/zap-advanced have some special settings that have not been touched Signed-off-by: Sebastian <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
…nsistency/value-files
This is necessary because the provided amass container has a non-numeric user that cannot be verified to be root or not: Error: container has runAsNonRoot and image has non-numeric user (user), cannot verify user is non-root (pod: "scan-amass-scanner-dummy-scan, container: amass) Signed-off-by: Sebastian <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
A non-numeric user cannot be checked to be non-root by Kubernetes and causes an error if runAsNonRoot is (justifiably) activated. Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Like Kubehunter Dockerfile, non-root user is not needed Signed-off-by: Sebastian <[email protected]>
Changes to USER did not yield the desired effect Signed-off-by: Sebastian <[email protected]>
For scanners: gitleaks, kube-hunter, ssh-scan, sslyze, trivy, wpscan, zap, zap-advanced Signed-off-by: Sebastian <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Member
|
@SebieF this seems to include a lot of changes from the other consistency pr's not just the cms seek |
Contributor
Author
|
Yeah :( but this should be no problem when the other PRs are merged first? |
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian Franz <[email protected]>
SebieF
force-pushed
the
consistency/cmseek
branch
from
6d60aec to
d859e7f
Compare
Signed-off-by: Sebastian Franz <[email protected]>
Signed-off-by: Sebastian Franz <[email protected]>
Necessary because unrelated files were included in the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because cmseek was added as a new security scanner while recent consistentcy refactoring was done, some files from cmseek do not follow the new template structure. This PR fixes all the inconsistencies with other scanners.
It also seems like the securityContext of values.yaml needs readOnlyRootFilesystem to be false (see #723).
Checklist