Add a warning about DefectDojo deduplication issue to the documentation#760
Merged
Add a warning about DefectDojo deduplication issue to the documentation#760
DefectDojo deduplication issue to the documentation#760Conversation
Signed-off-by: Max Maass <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Member
Author
|
Oh, I didn't see PR #757. If that one gets merged quickly, we should hold off on merging this PR and instead directly add a solution in the docs for excluding the DefectDojo hook for specific scans. However, we should still include some form of warning about the deduplication issue, as it is important to know that the issue exists (also for reasons of correctness of results). |
J12934
reviewed
Oct 22, 2021
Signed-off-by: Max Maass <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
rfelber
approved these changes
Oct 24, 2021
rfelber
changed the title
DefectDojo deduplication issue to the documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #746, I am adding a warning to the DefectDojo hook documentation to notify people about the potential issues related to the hook. Consider this a first draft and feel free to update the wording.