Run angularjs-csti As User In Container#852
Merged
Conversation
* A new user is added to the docker image * Path to wrapper.sh is changed to new user's home directory Signed-off-by: Ilyes Ben Dlala <[email protected]>
7 tasks
malexmave
reviewed
Dec 1, 2021
the same archive was installed twice by mistake this resolves that Signed-off-by: Ilyes Ben Dlala <[email protected]>
Member
|
@Ilyesbdlala can you double-check if the documentation requires updates as well because the paths changed? From a quick look, it seems like we have some references to absolute paths in the docs that may require changing. |
* the mount path for the config volume is corrected * readOnlyRootFileSystem in values is set to false to allow writing the config file (see wrapper.sh) Signed-off-by: Ilyes Ben Dlala <[email protected]>
this is the path to the volume mounted. to allow a config map to be used with angularjs-csti-scanner. Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Member
Author
|
This PR also sets readOnlyRootFileSystem in values.yaml is to false to allow the wrapper.sh to write to the config file. |
7 tasks
Signed-off-by: Max Maass <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: Max Maass <[email protected]>
malexmave
approved these changes
Dec 1, 2021
Member
malexmave
left a comment
malexmave
left a comment
There was a problem hiding this comment.
Tested, works on my machine (runs and also accepts and honors config files).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
angularjs-csti scanner now runs as NonRoot
home directory
It should be noted that angularjs-csti currently does not have any integration tests. So testing was done manually.
See: Dedicated User For Scanner Images #286