Skip to content

Comments

[SCB-Bot] Upgraded amass from v3.15.0 to v3.15.2#857

Merged
J12934 merged 1 commit intomainfrom
dependencies/upgrading-amass-to-v3.15.2
Dec 8, 2021
Merged

[SCB-Bot] Upgraded amass from v3.15.0 to v3.15.2#857
J12934 merged 1 commit intomainfrom
dependencies/upgrading-amass-to-v3.15.2

Conversation

@secureCodeBoxBot
Copy link
Contributor

@secureCodeBoxBot secureCodeBoxBot commented Dec 6, 2021 •
edited by Ilyesbdlala
Loading

This is an automated Pull Request by the SCB-Bot. It upgrades amass from v3.15.0 to v3.15.2

Release changes : here

@secureCodeBoxBot secureCodeBoxBot added dependencies Pull requests that update a dependency file scanner Implement or update a security scanner labels Dec 6, 2021
@J12934
Copy link
Member

J12934 commented Dec 6, 2021

@Ilyesbdlala seems like the inclusion of the cahnge log doesn't work correctly yet.

Could we simplify this maybe just a bit to link to the github release instead of including the entire changelog? I guess that would make this a lot simpler as we would have to worry about multi-line text, escaping and all that...

@Ilyesbdlala Ilyesbdlala mentioned this pull request Dec 7, 2021
Merged
3 tasks
@Ilyesbdlala
Copy link
Member

Ilyesbdlala commented Dec 7, 2021

@Ilyesbdlala seems like the inclusion of the cahnge log doesn't work correctly yet.

Could we simplify this maybe just a bit to link to the github release instead of including the entire changelog? I guess that would make this a lot simpler as we would have to worry about multi-line text, escaping and all that...

Yeah I agree. Trying to put the changelog in the PR body has been a game of Whac-A-Mole of different unexpected bugs. Apparently the "Github Actions" shell behaves a lot different to a sh or bash shell when it comes to var and string subtitutions.
I created a PR #860 to fix the issue. It seems to be working (#861). Feel free to review it.

I'm also gonna go ahead and fix the body of current SCB-Bot PRs manually.

Ilyesbdlala
Ilyesbdlala approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@Ilyesbdlala Ilyesbdlala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes https://github.com/OWASP/Amass/releases/tag/v3.15.1
Minor changes (mainly tests).

@Ilyesbdlala Ilyesbdlala mentioned this pull request Dec 7, 2021
Closed
@J12934 J12934 merged commit 6fe2ad2 into main Dec 8, 2021
@J12934 J12934 deleted the dependencies/upgrading-amass-to-v3.15.2 branch December 8, 2021 10:21
@J12934 J12934 mentioned this pull request Oct 2, 2022
Merged
@J12934 J12934 mentioned this pull request Oct 12, 2022
Merged
@rfelber rfelber mentioned this pull request Oct 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ilyesbdlala Ilyesbdlala Ilyesbdlala approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file scanner Implement or update a security scanner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@secureCodeBoxBot @J12934 @Ilyesbdlala