Replaces the changelog in the SCB-Bot PRs with a link to release#860
Merged
Replaces the changelog in the SCB-Bot PRs with a link to release#860
Conversation
Also added on push trigger and commented out sections for testing Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
Github releases sometimes have a "v" character in the beginning and sometimes not Signed-off-by: Ilyes Ben Dlala <[email protected]>
Signed-off-by: Ilyes Ben Dlala <[email protected]>
This was only added for testing Signed-off-by: Ilyes Ben Dlala <[email protected]>
This is done to fix the codeclimate failure Signed-off-by: Ilyes Ben Dlala <[email protected]>
J12934
reviewed
Dec 7, 2021
| run: | | ||
| changelog=$(curl -sL ${{env.versionApi}} | jq -r ".body") | ||
| echo 'releaseChangelog=$changelog' >> $GITHUB_ENV | ||
| changelog=$(echo ${{env.versionApi}} | sed -e 's/api.//g;s/\/repos//g;s/latest//g') |
Member
There was a problem hiding this comment.
Can you add a comment (maybe with an example) on what this replace looks like?
Had some problems properly understanding what this is doing
Explains how the formating of the release link works Signed-off-by: Ilyes Ben Dlala <[email protected]>
J12934
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the bug here where the changelog is wrongly substituted. Instead we just include the link to remote release.
PoC: #861
Description
Checklist
npm testruns for the whole project.