Open
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
jspaaks
suggested changes
Apr 7, 2021
Contributor
jspaaks
left a comment
jspaaks
left a comment
There was a problem hiding this comment.
Nice to dot the is and cross the ts on the release procedure
|
|
||
| # install in user space from test pypi instance: | ||
| python3 -m pip -v install --user --no-cache-dir \ | ||
| python3 -m pip -v install --no-cache-dir \ |
Contributor
There was a problem hiding this comment.
Add commands that create a new venv to replace the user space install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While preparing release 0.2.0, we found three issues in the documentation and code:
bumpversionwas not mentioned in the release preparation instructions (added)--usercaused an error (part removed)matplotlibis not a necessary requirement because sequgen does no plotting (requirement removed)These three issues have been fixed in this PR.