fix(light): tag dropdown, code highlight#3799
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Updates Written by Cursor Bugbot for commit 584504f. Configure here. |
Greptile SummaryThis PR fixes two light-mode visual regressions in the EMCN component library: the Confidence Score: 5/5Safe to merge — both changes are correct, targeted light-mode visual fixes with no logic or behavioural side-effects. Both fixes are straightforward CSS/Tailwind class corrections. The root cause (CSS variables resolving to light values inside an intentionally-dark inverted scheme) is clearly diagnosed and correctly addressed. No functional logic is changed, dark mode is unaffected, and the only remaining note is a low-priority maintenance suggestion about consolidating hardcoded hex values. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Render Popover / Code editor] --> B{colorScheme?}
B -->|default| C[Use CSS vars\nvar --surface-3 / var --border-1]
B -->|inverted| D{Host theme?}
D -->|light mode| E["Hardcoded dark values\n#1b1b1b bg / #363636 border\n(dark: classes skipped)"]
D -->|dark mode| F["CSS vars resolve correctly\ndark:bg-[var(--surface-3)]\ndark:border-[var(--border-1)]"]
E --> G[Dark popover in light mode ✓]
F --> H[Dark popover in dark mode ✓]
C --> I[Theme-adaptive popover ✓]
J[Code editor selection] --> K{Host theme?}
K -->|light mode| L["selection:text-[var(--text-primary)]\n= #1a1a1a on #add6ff ✓"]
K -->|dark mode| M["dark:selection:text-white\non #264f78 ✓"]
Reviews (1): Last reviewed commit: "remove more hardcoded vals" | Re-trigger Greptile |
Summary
Tag dropdown in light mode does not show up. Code highlight color is not in line with prod.
Type of Change
Testing
Tested manually
Checklist