fix(knowledge): show spinner on connector chip while syncing#3808
fix(knowledge): show spinner on connector chip while syncing#3808waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Moves the spinner indicator to appear next to the connector name (and also when Written by Cursor Bugbot for commit 559ad58. Configure here. |
.../workspace/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.tsx
Show resolved
Hide resolved
Greptile SummaryThis PR fixes the connector sync spinner so it only appears on the connector that was manually triggered, rather than relying on the global Confidence Score: 5/5Safe to merge — targeted, well-scoped UI fix with no logic regressions. The change is minimal and correct: No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant U as User
participant CC as ConnectorCard
participant CS as ConnectorsSection
participant API as triggerSync mutation
U->>CC: clicks Sync button
CC->>CS: onSync(connectorId)
CS->>CS: setSyncingConnectorId(connectorId)
CS->>API: triggerSync({ knowledgeBaseId, connectorId })
CS-->>CC: isSyncPending=true → Loader2 shown next to name
Note over CC: connector.status still 'active'
API-->>CS: onSuccess
CS->>CS: setSyncingConnectorId(null)
Note over CC: isSyncPending=false, spinner hides
Note over CC: connector.status transitions to 'syncing'
CC-->>CC: connector.status==='syncing' → spinner shown again
Note over CC: Badge shows 'Syncing' (amber)
Note over CC: Server finishes sync
CC-->>CC: connector.status==='active' → spinner hidden
Note over CC: Badge shows 'Active' (green)
Reviews (2): Last reviewed commit: "fix(knowledge): scope sync spinner to mu..." | Re-trigger Greptile |
.../workspace/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.tsx
Outdated
Show resolved
Hide resolved
|
@greptile |
|
@cursor review |
Summary
syncCooldowninstead of globalisSyncingso only the triggered connector shows the spinnerType of Change
Testing
Tested manually
Checklist