fix [] response on single notification

Martin Daetz · Martin Daetz · commit b71f56afe92d · 2015-02-05T17:14:57.000+01:00
diff --git a/AustinHarris.JsonRpcTest/UnitTest1.cs b/AustinHarris.JsonRpcTest/UnitTest1.cs
@@ -1340,10 +1340,16 @@ public void TestBatchResult()
             string request =
                 @"[{},{""jsonrpc"":""2.0"",""id"":4},{""jsonrpc"":""2.0"",""method"":""ReturnsDateTime"",""params"":{},""id"":1},{""jsonrpc"":""2.0"",""method"":""Notify"",""params"":[""Hello World!""]}]";
 
+            var secondRequest = @"{""jsonrpc"":""2.0"",""method"":""Notify"",""params"":[""Hello World!""]}";
             var result = JsonRpcProcessor.Process(request);
             result.Wait();
 
             Assert.IsFalse(result.Result.EndsWith(@",]"), "result.Result.EndsWith(@',]')");
+
+            result = JsonRpcProcessor.Process(secondRequest);
+            result.Wait();
+
+            Assert.IsTrue(string.IsNullOrEmpty(result.Result));
         }
     }
 }
diff --git a/Json-Rpc/JsonRpcProcessor.cs b/Json-Rpc/JsonRpcProcessor.cs
@@ -121,7 +121,7 @@ private static string ProcessInternal(string sessionId, string jsonRpc, object j
                     responses[idx++] = JsonConvert.SerializeObject(resp.Item2);
                 }
 
-                return responses.Length == 1 ? responses[0] : string.Format("[{0}]", string.Join(",", responses));
+                return responses.Length == 0 ? string.Empty : responses.Length == 1 ? responses[0] : string.Format("[{0}]", string.Join(",", responses));
             }
             catch (Exception ex)
             {

Original file line number	Diff line number	Diff line change
`@@ -1340,10 +1340,16 @@ public void TestBatchResult()`
`1340`	`1340`	`string request =`
`1341`	`1341`	`@"[{},{""jsonrpc"":""2.0"",""id"":4},{""jsonrpc"":""2.0"",""method"":""ReturnsDateTime"",""params"":{},""id"":1},{""jsonrpc"":""2.0"",""method"":""Notify"",""params"":[""Hello World!""]}]";`
`1342`	`1342`
	`1343`	`+ var secondRequest = @"{""jsonrpc"":""2.0"",""method"":""Notify"",""params"":[""Hello World!""]}";`
`1343`	`1344`	`var result = JsonRpcProcessor.Process(request);`
`1344`	`1345`	`result.Wait();`
`1345`	`1346`
`1346`	`1347`	`Assert.IsFalse(result.Result.EndsWith(@",]"), "result.Result.EndsWith(@',]')");`
	`1348`	`+`
	`1349`	`+ result = JsonRpcProcessor.Process(secondRequest);`
	`1350`	`+ result.Wait();`
	`1351`	`+`
	`1352`	`+ Assert.IsTrue(string.IsNullOrEmpty(result.Result));`
`1347`	`1353`	`}`
`1348`	`1354`	`}`
`1349`	`1355`	`}`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ private static string ProcessInternal(string sessionId, string jsonRpc, object j`
`121`	`121`	`responses[idx++] = JsonConvert.SerializeObject(resp.Item2);`
`122`	`122`	`}`
`123`	`123`
`124`		`- return responses.Length == 1 ? responses[0] : string.Format("[{0}]", string.Join(",", responses));`
	`124`	`+ return responses.Length == 0 ? string.Empty : responses.Length == 1 ? responses[0] : string.Format("[{0}]", string.Join(",", responses));`
`125`	`125`	`}`
`126`	`126`	`catch (Exception ex)`
`127`	`127`	`{`