Merged
Conversation
- minor renaming make consistent with node and golang code review exercise
- update lock make consistent with node and golang code review exercise
- wip - same result as node but failing tests make consistent with node and golang code review exercise
- wip - refactor - same result as node but failing tests make consistent with node and golang code review exercise
- wip - refactor - same result as node but failing tests make consistent with node and golang code review exercise
tests make consistent with node and golang code review exercise
adds unit test for resolved_dependencies make consistent with node and golang code review exercise
renaming and improve test make consistent with node and golang code review exercise
rachelcdavies
force-pushed
the
feat/resolve-first-layer-deps
branch
from
51582ca to
d90294c
Compare
rename test make consistent with node and golang code review exercise
pablo-snyk
reviewed
Feb 19, 2025
rachelcdavies
commented
Feb 19, 2025
pablo-snyk
reviewed
Feb 19, 2025
adds suggestion from review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the resolution of first-level of dependencies.
This is not the PR for candidates to review
Context
We're doing this to make consistent with Node and Golang code review exercise
https://snyksec.atlassian.net/browse/RKT-3299