Skip to content

Allow dragging extrusions by dragging the end faces. Add the face poi…#1600

Merged
phkahler merged 1 commit intosolvespace:masterfrom
phkahler:drag-faces
Nov 30, 2025
Merged

Allow dragging extrusions by dragging the end faces. Add the face poi…#1600
phkahler merged 1 commit intosolvespace:masterfrom
phkahler:drag-faces

Conversation

@phkahler
Copy link
Member

…nt to the dragged list.

This does not work yet. It seems that ChooseFromHoverToSelect() and ChooseFromHoverToDrag() never recieve face entites. If they don't I'm not sure how faces get selected.

@phkahler
Copy link
Member Author

We did a lot of face selection in #1258. I'll look through some of those areas...

@ruevs ruevs marked this pull request as draft August 5, 2025 13:42
@phkahler
Copy link
Member Author

Looking at some other code for hover and selection faces are never added to the hoverlist. A variable called "hover" will be set near the end of the function but that is distinct from hoverList. Dragging grabs something from the hoverList, and faces won't be in there.

So it looks like HitTestMakeSelection() uses a local "sel" to hold the one item that will be selected on click, but at the end it is transferred to "hover" which is part of the class. hoverList holds everything that is under the mouse pointer so slightly different logic can be used for dragging. This could be cleaned up a bit... Hmmm did I split out the function ChooseFromHoverToDrag() ?? I know I added the "CanBeDragged" function to get click-through working right.

…cular surfaces create by Lathe or Revolve to drag the previous group line that swept out the surface - this was unexpected but cool. Dragging other faces will need investigation as indicated in the comments.
@phkahler
Copy link
Member Author

I finally got this! So easy too. The behavior on Lathe and Revolve was total bonus!

I'd like to do faces for linked and other groups separately because I think they need more surgery.

@ruevs ruevs marked this pull request as ready for review November 30, 2025 19:12
@ruevs
Copy link
Member

ruevs commented Nov 30, 2025

This boiled down to a really trivial change after all :-)

But the (stupid) macOS CI is failing again :-( Not because of you... just Mac stuff :-(

@phkahler phkahler merged commit e3f21de into solvespace:master Nov 30, 2025
6 of 8 checks passed
@ruevs ruevs added the UI label Dec 1, 2025
@phkahler phkahler deleted the drag-faces branch December 28, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants